Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add solutions to leetcode problem No.0633. Sum of Square Numbers #359

Merged
merged 1 commit into from
Apr 28, 2021
Merged

feat: add solutions to leetcode problem No.0633. Sum of Square Numbers #359

merged 1 commit into from
Apr 28, 2021

Conversation

maolonglong
Copy link
Member

@maolonglong maolonglong commented Apr 28, 2021 •
edited
Loading

添加了 633 的 Python3 和 Java 解法

yanglbme
yanglbme requested changes Apr 28, 2021
View reviewed changes
Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要在 README_EN.md 同步题解，但不要有中文解法描述。
  2. 需要增加对应的 Solution.py, Solution.java 文件。Solution.java 已有，可修改为你的题解，保持一致。

@yanglbme
Copy link
Member

你好 @maolonglong 目前有中英版本：README.md 和 README_EN.md，所以麻烦同步一下两个文件的题解哈~

@maolonglong
Copy link
Member Author

不好意思，前面没注意到项目结构

@yanglbme
Copy link
Member

感谢，非常规范的一次提交。

@yanglbme yanglbme merged commit f40e0dc into doocs:main Apr 28, 2021
@maolonglong
Copy link
Member Author

😃 哈哈，最近开始学习 git，刚好尝试参与一些优秀的项目，感谢您提供的机会

@yanglbme
Copy link
Member

@maolonglong 期待你更多的 contributions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maolonglong @yanglbme